TaoZex commented on code in PR #6684:
URL: https://github.com/apache/seatunnel/pull/6684#discussion_r1560743704
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/source/enumerator/splitter/JdbcSourceChunkSplitter.java:
##########
@@ -54,12 +68,19 @@ Object[] queryMinMax(JdbcConnection jdbc, TableId tableId,
String columnName)
*
* @param jdbc JDBC connection.
* @param tableId table identity.
- * @param columnName column name.
+ * @param column column.
* @param excludedLowerBound the minimum value should be greater than this
value.
* @return minimum value.
*/
- Object queryMin(
- JdbcConnection jdbc, TableId tableId, String columnName, Object
excludedLowerBound)
+ default Object queryMin(
+ JdbcConnection jdbc, TableId tableId, Column column, Object
excludedLowerBound)
+ throws SQLException {
+ return queryMin(jdbc, tableId, column.name(), excludedLowerBound);
+ }
+
+ @Deprecated
+ Object[] sampleDataFromColumn(
+ JdbcConnection jdbc, TableId tableId, String columnName, int
samplingRate)
Review Comment:
Add code comment
```suggestion
/**
* @deprecated instead by {@link
this#sampleDataFromColumn(JdbcConnection, TableId, Column, samplingRate}
*/
@Deprecated
Object[] sampleDataFromColumn(
JdbcConnection jdbc, TableId tableId, String columnName, int
samplingRate)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
