SbloodyS commented on code in PR #6685:
URL: https://github.com/apache/seatunnel/pull/6685#discussion_r1561950455


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceReader.java:
##########
@@ -171,6 +171,9 @@ public void pollNext(Collector<SeaTunnelRow> output) throws 
Exception {
                                                                 && 
record.offset()
                                                                         >= 
sourceSplit
                                                                                
 .getEndOffset()) {
+                                                            // signal to the 
source that we have

Review Comment:
   Currently, In Batch mode The `pollNext` will only be executed once because 
`KafkaConsumer.poll` can only be consume limited data restricted by 
`max.poll.records` and its timeout. Moving it internally can enable `poolNext` 
to execute multiple times to consume data. @Hisoka-X 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to