dailai commented on code in PR #6740: URL: https://github.com/apache/seatunnel/pull/6740#discussion_r1577029408
########## seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/reader/fetcher/SplitFetcherManager.java: ########## Review Comment: > Hi brother, did you copy the code from PR(#6288) instead of merging? I just referenced this pr's code, but did not directly merge his code. There are three main reasons: **First,** we are based on a different version of seatunnel and there are a lot of cdc pr changes in the meantime. **Second,** the original authors did not solve all the problems, e2e test did not pass all which not all right; **Third,** I saw some cdc copy the higher version of debezium class, but without any custom logic, that pr chose to keep them, I don't think this is the right thing to do. As for here, I am in order to solve the problem which is could not find the class io.debezium. Relational. History when upgrade debezium to 1.9.8. I debug the code and find that after upgrading the debezium version, I runed the cdc task. From the code here, the classloader changes from seatunnelclassloader to appclassloader. I came up with two solutions: **First,** change it this way like here which can be the same as before. **Second,** set the classloader at line 142 in io.debezium.relational.HistorizedRelationalDatabaseConnectorConfig. I chose the first option because I wanted to keep the classloader of the cdc task the same as before the upgrade -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
