(seatunnel) branch dev updated: [Fix][KuduCatalogFactory]: Fix KuduCatalogFactory.optionRule() will throw an Exception (#6787)

[zhouyao2023]

This is an automated email from the ASF dual-hosted git repository.

zhouyao2023 pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 45a4e1532d [Fix][KuduCatalogFactory]: Fix 
KuduCatalogFactory.optionRule() will throw an Exception (#6787)
45a4e1532d is described below

commit 45a4e1532d64207e60da771ecf67c80d19970156
Author: TeAmo <93769000+jetia...@users.noreply.github.com>
AuthorDate: Mon May 6 15:04:17 2024 +0800

    [Fix][KuduCatalogFactory]: Fix KuduCatalogFactory.optionRule() will throw 
an Exception (#6787)
    
    * fix(KuduCatalogFactory): Fix KuduCatalogFactory.optionRule() will throw 
an Exception
    
    Fix `KuduCatalogFactory.optionRule()` will throw an Exception because 
conditional OptionRule should be in the optinal or required options.
    
    * [Feat][KuduFactoryTest]: Add a Test On KuduFactory
    
    1. Add a Test On KuduFactory
---
 .../seatunnel/connectors/seatunnel/kudu/catalog/KuduCatalogFactory.java | 1 +
 .../org/apache/seatunnel/connectors/seatunnel/kudu/KuduFactoryTest.java | 2 ++
 2 files changed, 3 insertions(+)

diff --git 
a/seatunnel-connectors-v2/connector-kudu/src/main/java/org/apache/seatunnel/connectors/seatunnel/kudu/catalog/KuduCatalogFactory.java
 
b/seatunnel-connectors-v2/connector-kudu/src/main/java/org/apache/seatunnel/connectors/seatunnel/kudu/catalog/KuduCatalogFactory.java
index 6ebf783604..c3f6579b2f 100644
--- 
a/seatunnel-connectors-v2/connector-kudu/src/main/java/org/apache/seatunnel/connectors/seatunnel/kudu/catalog/KuduCatalogFactory.java
+++ 
b/seatunnel-connectors-v2/connector-kudu/src/main/java/org/apache/seatunnel/connectors/seatunnel/kudu/catalog/KuduCatalogFactory.java
@@ -60,6 +60,7 @@ public class KuduCatalogFactory implements CatalogFactory {
                 .optional(OPERATION_TIMEOUT)
                 .optional(ADMIN_OPERATION_TIMEOUT)
                 .optional(KERBEROS_KRB5_CONF)
+                .optional(ENABLE_KERBEROS)
                 .conditional(ENABLE_KERBEROS, true, KERBEROS_PRINCIPAL, 
KERBEROS_KEYTAB)
                 .build();
     }
diff --git 
a/seatunnel-connectors-v2/connector-kudu/src/test/java/org/apache/seatunnel/connectors/seatunnel/kudu/KuduFactoryTest.java
 
b/seatunnel-connectors-v2/connector-kudu/src/test/java/org/apache/seatunnel/connectors/seatunnel/kudu/KuduFactoryTest.java
index b779cf492e..f4141cbd94 100644
--- 
a/seatunnel-connectors-v2/connector-kudu/src/test/java/org/apache/seatunnel/connectors/seatunnel/kudu/KuduFactoryTest.java
+++ 
b/seatunnel-connectors-v2/connector-kudu/src/test/java/org/apache/seatunnel/connectors/seatunnel/kudu/KuduFactoryTest.java
@@ -17,6 +17,7 @@
 
 package org.apache.seatunnel.connectors.seatunnel.kudu;
 
+import 
org.apache.seatunnel.connectors.seatunnel.kudu.catalog.KuduCatalogFactory;
 import org.apache.seatunnel.connectors.seatunnel.kudu.sink.KuduSinkFactory;
 import org.apache.seatunnel.connectors.seatunnel.kudu.source.KuduSourceFactory;
 
@@ -29,5 +30,6 @@ class KuduFactoryTest {
     void optionRule() {
         Assertions.assertNotNull((new KuduSourceFactory()).optionRule());
         Assertions.assertNotNull((new KuduSinkFactory()).optionRule());
+        Assertions.assertNotNull((new KuduCatalogFactory()).optionRule());
     }
 }