hailin0 commented on code in PR #5992:
URL: https://github.com/apache/seatunnel/pull/5992#discussion_r1595256071
##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/debezium/DebeziumJsonDeserializationSchema.java:
##########
@@ -71,19 +77,42 @@ public DebeziumJsonDeserializationSchema(
this.rowType = rowType;
this.ignoreParseErrors = ignoreParseErrors;
this.jsonDeserializer =
- new JsonDeserializationSchema(false, ignoreParseErrors,
createJsonRowType(rowType));
+ new JsonDeserializationSchema(
+ false, ignoreParseErrors, createJsonRowType(rowType),
catalogTable);
this.debeziumRowConverter = new DebeziumRowConverter(rowType);
this.debeziumEnabledSchema = debeziumEnabledSchema;
}
+ public DebeziumJsonDeserializationSchema(
+ SeaTunnelRowType rowType,
+ boolean ignoreParseErrors,
+ boolean debeziumEnabledSchema,
+ CatalogTable catalogTable) {
+ this.rowType = rowType;
Review Comment:
```suggestion
public DebeziumJsonDeserializationSchema(
CatalogTable catalogTable,
boolean ignoreParseErrors,
boolean debeziumEnabledSchema) {
this.rowType = catalogTable.getSeaTunnelRowType();
```
##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/debezium/DebeziumJsonDeserializationSchema.java:
##########
@@ -71,19 +77,42 @@ public DebeziumJsonDeserializationSchema(
this.rowType = rowType;
this.ignoreParseErrors = ignoreParseErrors;
this.jsonDeserializer =
- new JsonDeserializationSchema(false, ignoreParseErrors,
createJsonRowType(rowType));
+ new JsonDeserializationSchema(
+ false, ignoreParseErrors, createJsonRowType(rowType),
catalogTable);
this.debeziumRowConverter = new DebeziumRowConverter(rowType);
this.debeziumEnabledSchema = debeziumEnabledSchema;
}
+ public DebeziumJsonDeserializationSchema(
+ SeaTunnelRowType rowType,
+ boolean ignoreParseErrors,
+ boolean debeziumEnabledSchema,
+ CatalogTable catalogTable) {
+ this.rowType = rowType;
Review Comment:
Update all places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
