Hisoka-X commented on code in PR #6843:
URL: https://github.com/apache/seatunnel/pull/6843#discussion_r1601047551
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/dag/logical/LogicalDag.java:
##########
@@ -129,40 +141,47 @@ public int getClassId() {
@Override
public void writeData(ObjectDataOutput out) throws IOException {
out.writeInt(logicalVertexMap.size());
-
for (Map.Entry<Long, LogicalVertex> entry :
logicalVertexMap.entrySet()) {
out.writeLong(entry.getKey());
out.writeObject(entry.getValue());
}
out.writeInt(edges.size());
-
for (LogicalEdge edge : edges) {
out.writeObject(edge);
}
+ out.writeInt(saveModeList.size());
+ for (SupportSaveMode saveMode : saveModeList) {
Review Comment:
In fact, the current SupportSaveMode declarations are all on the
SeaTunnelSink implementation class, and all SeaTunnelSinks are serializable by
default. It is also engine-independent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
