EricJoy2048 commented on code in PR #6842: URL: https://github.com/apache/seatunnel/pull/6842#discussion_r1630575565
########## docs/en/connector-v2/sink/Hive.md: ########## @@ -33,7 +33,7 @@ By default, we use 2PC commit to ensure `exactly-once` | name | type | required | default value | |-------------------------------|---------|----------|----------------| | table_name | string | yes | - | -| metastore_uri | string | yes | - | +| hive_jdbc_url | string | yes | - | Review Comment: > yes. but if we want use savemode feature only with hive metastore, is difficulty to create table. like table format, bucket setting, table location etc. we need lots of parameter to config them. so i want use sql template to let user define the template we can replace table name, columns in this template and run the sql to create table. > > I can add metastore_url back, and it will make the code more easier. But user need both config `jdbc` and `thrift` on hive connector. Yes, you can add `metastore_url ` back and tell users `save mode` only can be use when `jdbc_url` is configed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
