litiliu commented on code in PR #6960:
URL: https://github.com/apache/seatunnel/pull/6960#discussion_r1635767699


##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/filter/FilterFieldTransform.java:
##########
@@ -36,21 +36,39 @@
 
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
 import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 @Slf4j
 public class FilterFieldTransform extends AbstractCatalogSupportTransform {
     public static final String PLUGIN_NAME = "Filter";
-    private int[] inputValueIndex;
-    private final List<String> fields;
+
+    private int[] inputValueIndexList;
+
+    private final List<String> includeFields;
+    private final List<String> excludeFields;
 
     public FilterFieldTransform(
             @NonNull ReadonlyConfig config, @NonNull CatalogTable 
catalogTable) {
         super(catalogTable);
         SeaTunnelRowType seaTunnelRowType = 
catalogTable.getTableSchema().toPhysicalRowDataType();
-        fields = config.get(FilterFieldTransformConfig.KEY_FIELDS);
+        includeFields = config.get(FilterFieldTransformConfig.INCLUDE_FIELDS);
+        excludeFields = config.get(FilterFieldTransformConfig.EXCLUDE_FIELDS);
+        // only one should be set
+        if (Objects.nonNull(includeFields) && Objects.nonNull(excludeFields)) {

Review Comment:
   fixed, PTAL again @EricJoy2048 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to