Hisoka-X commented on code in PR #7045:
URL: https://github.com/apache/seatunnel/pull/7045#discussion_r1650745838
##########
docs/sidebars.js:
##########
@@ -178,7 +178,8 @@ const sidebars = {
"seatunnel-engine/checkpoint-storage",
"seatunnel-engine/rest-api",
"seatunnel-engine/tcp",
- "seatunnel-engine/engine-jar-storage-mode"
+ "seatunnel-engine/engine-jar-storage-mode",
+ "seatunnel-engine/resource-manager",
Review Comment:
how about named this part as `Resource Isolation`?
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/ReadonlyConfig.java:
##########
@@ -96,6 +96,10 @@ public void toMap(Map<String, String> result) {
}
}
+ public Map<String, Object> getMapConfig() {
Review Comment:
```suggestion
public Map<String, Object> getSourceMap() {
```
##########
seatunnel-examples/seatunnel-engine-examples/src/main/resources/examples/fake_to_console.conf:
##########
@@ -21,6 +21,10 @@
env {
parallelism = 1
job.mode = "BATCH"
+ tag_filter {
+ group = "platform"
+ team = "team1"
+ }
Review Comment:
Please revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
