Hisoka-X commented on code in PR #7311:
URL: https://github.com/apache/seatunnel/pull/7311#discussion_r1706370962
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
##########
@@ -666,6 +667,16 @@ default String decorateWithComment(
return sql.toString();
}
+ default String decorateOceanBaseWithComment(
+ String basicSql, BasicTypeDefine<OceanBaseMysqlType>
typeBasicTypeDefine) {
+ String comment = typeBasicTypeDefine.getComment();
+ StringBuilder sql = new StringBuilder(basicSql);
+ if (StringUtils.isNotBlank(comment)) {
+ sql.append("COMMENT '").append(comment).append("'");
+ }
+ return sql.toString();
+ }
Review Comment:
It is strange to add method for oceanbase in jdbcdiaect. I think we should
`remove all MysqlType references in JdbcDialect`.
https://github.com/apache/seatunnel/pull/7311#issuecomment-2272571440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
