Hisoka-X commented on code in PR #7247:
URL: https://github.com/apache/seatunnel/pull/7247#discussion_r1709362599
##########
config/seatunnel.yaml:
##########
@@ -22,6 +22,7 @@ seatunnel:
queue-type: blockingqueue
print-execution-info-interval: 60
print-job-metrics-info-interval: 60
+ log-privacy-keyword: username,password,passwd,token,jwt,secret
Review Comment:
At this stage, there is no need to introduce this parameter, because the
configuration printing config is effective for all engines, but this
configuration file is only used for zeta.
##########
seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java:
##########
@@ -94,9 +99,57 @@ public static Config of(@NonNull Map<String, Object>
objectMap, boolean isEncryp
if (!isEncrypt) {
config = ConfigShadeUtils.decryptConfig(config);
}
+ log.info("Parsed config file: \n{}",
mapToJson(privacyHandler(config.root().unwrapped())));
return config;
}
+ public static Map<String, Object> privacyHandler(Map<String, Object>
configMap) {
+ List<String> logPrivacyKeyword =
seaTunnelConfig.getEngineConfig().getLogPrivacyKeyword();
Review Comment:
Please just use
https://github.com/apache/seatunnel/blob/16950a67cd5990ed3510fd91564390e2ab2cd44c/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java#L50
as value for now.
##########
seatunnel-core/seatunnel-core-starter/pom.xml:
##########
@@ -38,6 +38,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-engine-common</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
Review Comment:
-1. we should not include this dependency. The starter for all engine, not
only for zeta.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
