arshadmohammad commented on code in PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#discussion_r1712606007
########## seatunnel-datasource/seatunnel-datasource-plugins/datasource-console/src/main/java/org/apache/seatunnel/datasource/plugin/console/ConsoleDataSourceConfig.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.datasource.plugin.console; + +import org.apache.seatunnel.api.configuration.Option; +import org.apache.seatunnel.api.configuration.Options; +import org.apache.seatunnel.api.configuration.util.OptionRule; +import org.apache.seatunnel.datasource.plugin.api.DataSourcePluginInfo; +import org.apache.seatunnel.datasource.plugin.api.DatasourcePluginTypeEnum; + +public class ConsoleDataSourceConfig { + + public static final String PLUGIN_NAME = "Console"; + + public static final DataSourcePluginInfo CONSOLE_DATASOURCE_PLUGIN_INFO = + DataSourcePluginInfo.builder() + .name(PLUGIN_NAME) + .icon(PLUGIN_NAME) + .version("1.0.0") + .type(DatasourcePluginTypeEnum.FAKE_CONNECTION.getCode()) + .build(); + + public static final Option<String> URL = + Options.key("url") + .stringType() + .defaultValue("dummy://URL") + .withDescription( + "This is required to meet the design constraints, however, it won't be utilized during execution."); Review Comment: From my understanding, we are dealing with two components here: the datasource and the connector. The options LOG_PRINT_DATA and LOG_PRINT_DELAY are associated with the console connector. Incorporating these options into the console datasource would be as ineffective as the URL. It appears to me that connector options are directly populated from the connector jars, eliminating the need for additional code for these options. This arrangement works well for FakeSource, but it seems to be ineffective for Console. I will investigate why this is the case for Console. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
