TyrantLucifer commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712905056
##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.java:
##########
@@ -42,9 +40,7 @@
@Slf4j
public class FlinkRowCollector implements Collector<SeaTunnelRow> {
- private ReaderOutput<Row> readerOutput;
-
- private final FlinkRowConverter rowSerialization;
Review Comment:
Not need, because the relevant metrics statistics and current limiting logic
are all executed within this.
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/DataStreamTableInfo.java:
##########
@@ -18,20 +18,22 @@
package org.apache.seatunnel.core.starter.flink.execution;
import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
import org.apache.flink.streaming.api.datastream.DataStream;
-import org.apache.flink.types.Row;
import lombok.AllArgsConstructor;
import lombok.Data;
+import java.util.List;
+
@Data
@AllArgsConstructor
public class DataStreamTableInfo {
- private DataStream<Row> dataStream;
+ private DataStream<SeaTunnelRow> dataStream;
- private CatalogTable catalogTable;
+ private List<CatalogTable> catalogTable;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
