This is an automated email from the ASF dual-hosted git repository.
fanjia pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new ac87ba0bbe [Improve] Update pull request template and github action
guide (#7376)
ac87ba0bbe is described below
commit ac87ba0bbef4b48c3772d185d45128d7f5468f57
Author: Jia Fan <[email protected]>
AuthorDate: Fri Aug 16 15:53:03 2024 +0800
[Improve] Update pull request template and github action guide (#7376)
---
.github/PULL_REQUEST_TEMPLATE.md | 14 +++++++-------
.github/workflows/notify_test_workflow.yml | 3 ++-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index d4a3001e52..dab838235c 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -7,13 +7,9 @@ remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
-
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
-
- Name the pull request in the form "[Feature] [component] Title of the pull
request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
-
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-
-->
### Purpose of this pull request
@@ -22,6 +18,7 @@ Feel free to ping committers for the review!
### Does this PR introduce _any_ user-facing change?
+
<!--
Note that it means *any* user-facing change including all aspects such as the
documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes -
provide the console output, description and/or an example to show the behavior
difference if possible.
@@ -32,6 +29,7 @@ If you are adding/modifying connector documents, please
follow our new specifica
### How was this patch tested?
+
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
@@ -46,7 +44,9 @@ If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatu
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the
following files are updated:
- 1. Update change log that in connector document. For more details you can
refer to
[connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
- 2. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
- 3. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
+ 1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
+ 2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
+ 3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
+ 4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
+ 5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
* [ ] Update the
[`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
\ No newline at end of file
diff --git a/.github/workflows/notify_test_workflow.yml
b/.github/workflows/notify_test_workflow.yml
index ca0951dd63..58d1b5f2be 100644
--- a/.github/workflows/notify_test_workflow.yml
+++ b/.github/workflows/notify_test_workflow.yml
@@ -93,7 +93,8 @@ jobs:
Unable to detect the workflow run for testing the changes in your
PR.
1. If you did not enable GitHub Actions in your forked repository,
please enable it by clicking the button as shown in the image below. See also
[Disabling or limiting GitHub Actions for a
repository](https://docs.github.com/en/github/administering-a-repository/disabling-or-limiting-github-actions-for-a-repository)
for more details.
- 2. It is possible your branch is based on the old \`dev\` branch
in Apache SeaTunnel, please sync your branch to the latest dev branch. For
example as below:
+ 2. Create and push an empty commit to trigger the workflow.
+ 3. It is possible your branch is based on the old \`dev\` branch
in Apache SeaTunnel, please sync your branch to the latest dev branch. For
example as below:
\`\`\`bash
git fetch upstream
git rebase upstream/dev
