Hisoka-X commented on code in PR #7421:
URL: https://github.com/apache/seatunnel/pull/7421#discussion_r1720568006


##########
docs/en/connector-v2/source/Elasticsearch.md:
##########
@@ -54,11 +55,15 @@ x-pack password.
 
 Elasticsearch index name, support * fuzzy matching.
 
+### schema [config]
+
+The schema config in ElasticSearch sink is deprecated, please use source 
config instead! Choose between schema and source, it is recommended to use 
source
+
 ### source [array]
 
 The fields of index.
 You can get the document id by specifying the field `_id`.If sink _id to other 
index,you need specify an alias for _id due to the Elasticsearch limit.
-If you don't config source, it is automatically retrieved from the mapping of 
the index.
+If you don't config source, it is automatically retrieved from the mapping of 
the index.Choose between schema and source, it is recommended to use source

Review Comment:
   ```suggestion
   If you don't config source, it is automatically retrieved from the mapping 
of the index.
   ```



##########
docs/en/connector-v2/source/Elasticsearch.md:
##########
@@ -54,11 +55,15 @@ x-pack password.
 
 Elasticsearch index name, support * fuzzy matching.
 
+### schema [config]
+
+The schema config in ElasticSearch sink is deprecated, please use source 
config instead! Choose between schema and source, it is recommended to use 
source

Review Comment:
   ```suggestion
   The structure of the data, including field names and field types. Reference 
to [Schema-Feature](../../concept/schema-feature.md)
   The schema config in ElasticSearch sink is deprecated, please use source 
config instead.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to