Hisoka-X commented on code in PR #7169:
URL: https://github.com/apache/seatunnel/pull/7169#discussion_r1738078226
##########
docs/zh/connector-v2/sink/Hbase.md:
##########
@@ -15,7 +15,7 @@
| 名称 | 类型 | 是否必须 | 默认值 |
|--------------------|---------|------|-----------------|
| zookeeper_quorum | string | yes | - |
-| table | string | yes | - |
+| table | string | no | - |
Review Comment:
Seem like the doc not up to date.
##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/sink/HbaseSinkFactory.java:
##########
@@ -59,4 +67,16 @@ public OptionRule optionRule() {
HBASE_EXTRA_CONFIG)
.build();
}
+
+ @Override
+ public TableSink createSink(TableSinkFactoryContext context) {
+ TableSinkFactoryContext.replacePlaceholderAndCreate(
+ context.getCatalogTable(),
+ context.getOptions(),
+ Thread.currentThread().getContextClassLoader(),
+ Collections.emptyList());
Review Comment:
We already invoked this method in
https://github.com/apache/seatunnel/blob/df210ea73d5b14b36b9637fc4d12bee09fa8decd/seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/TableSinkFactoryContext.java#L51
So we shouldn't invoke it in connector. Please remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
