hailin0 commented on code in PR #7502:
URL: https://github.com/apache/seatunnel/pull/7502#discussion_r1741482276


##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/source/ElasticsearchSourceFactory.java:
##########
@@ -55,7 +52,7 @@ public String factoryIdentifier() {
     @Override
     public OptionRule optionRule() {
         return OptionRule.builder()
-                .required(HOSTS, INDEX)

Review Comment:
   Is it compatible with old versions?



##########
docs/en/connector-v2/source/Elasticsearch.md:
##########
@@ -19,24 +19,25 @@ support version >= 2.x and <= 8.x.
 
 ## Options
 
-|          name           |  type   | required |   default value   |

Review Comment:
   Why is the `index_list` not added?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to