Hisoka-X commented on PR #7567: URL: https://github.com/apache/seatunnel/pull/7567#issuecomment-2328711875
> > Hi @loustler , I thinked about it again, is it possible to add a UT to cover the newly added logic? > > Hi @Hisoka-X > > What does a UT means? What a UT stand for? > > You mean Unit Test? If it correct, how about a new e2e test case for it? Sorry. You are right, unit test. But I think add a e2e test case for this small feature is too heavy. We can add some unit test in https://github.com/apache/seatunnel/tree/e31c9c2a9a0804fd24f3ad16ab28fa4fd7ecc2bb/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb . Just like other connectors did. Please refer https://github.com/apache/seatunnel/blob/e31c9c2a9a0804fd24f3ad16ab28fa4fd7ecc2bb/seatunnel-connectors-v2/connector-elasticsearch/src/test/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/ElasticsearchRowSerializerTest.java#L40 or https://github.com/apache/seatunnel/blob/e31c9c2a9a0804fd24f3ad16ab28fa4fd7ecc2bb/seatunnel-connectors-v2/connector-paimon/src/test/java/org/apache/seatunnel/connectors/seatunnel/paimon/utils/RowConverterTest.java#L65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
