This is an automated email from the ASF dual-hosted git repository.

wuchunfu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 41002a17d9 [hotfix] fix FixSlotResourceTest unstable issue (#7577)
41002a17d9 is described below

commit 41002a17d984192b3ad546c8ffdc727a40fcf6a1
Author: Jarvis <[email protected]>
AuthorDate: Wed Sep 4 20:44:33 2024 +0800

    [hotfix] fix FixSlotResourceTest unstable issue (#7577)
---
 .../server/resourcemanager/FixSlotResourceTest.java     | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git 
a/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/resourcemanager/FixSlotResourceTest.java
 
b/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/resourcemanager/FixSlotResourceTest.java
index b3df40f6aa..53cc68b942 100644
--- 
a/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/resourcemanager/FixSlotResourceTest.java
+++ 
b/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/resourcemanager/FixSlotResourceTest.java
@@ -35,19 +35,32 @@ import static org.awaitility.Awaitility.await;
 
 public class FixSlotResourceTest extends 
AbstractSeaTunnelServerTest<FixSlotResourceTest> {
 
+    private final int totalSlots = 3;
+
     @Override
     public SeaTunnelConfig loadSeaTunnelConfig() {
         SeaTunnelConfig seaTunnelConfig = super.loadSeaTunnelConfig();
         SlotServiceConfig slotServiceConfig =
                 seaTunnelConfig.getEngineConfig().getSlotServiceConfig();
         slotServiceConfig.setDynamicSlot(false);
-        slotServiceConfig.setSlotNum(3);
+        slotServiceConfig.setSlotNum(totalSlots);
         
seaTunnelConfig.getEngineConfig().setSlotServiceConfig(slotServiceConfig);
         return seaTunnelConfig;
     }
 
     @Test
     public void testEnoughResource() throws ExecutionException, 
InterruptedException {
+        // wait all slot ready
+        await().atMost(20000, TimeUnit.MILLISECONDS)
+                .untilAsserted(
+                        () -> {
+                            Assertions.assertEquals(
+                                    totalSlots,
+                                    server.getCoordinatorService()
+                                            .getResourceManager()
+                                            .getUnassignedSlots(null)
+                                            .size());
+                        });
         long jobId = System.currentTimeMillis();
         List<ResourceProfile> resourceProfiles = new ArrayList<>();
         resourceProfiles.add(new ResourceProfile());
@@ -83,7 +96,7 @@ public class FixSlotResourceTest extends 
AbstractSeaTunnelServerTest<FixSlotReso
                 .untilAsserted(
                         () -> {
                             Assertions.assertEquals(
-                                    3,
+                                    totalSlots,
                                     server.getCoordinatorService()
                                             .getResourceManager()
                                             .getUnassignedSlots(null)

Reply via email to