Hisoka-X commented on code in PR #7608:
URL: https://github.com/apache/seatunnel/pull/7608#discussion_r1750185134
##########
seatunnel-connectors-v2/connector-iceberg/src/test/java/org/apache/seatunnel/connectors/seatunnel/iceberg/utils/SchemaUtilsTest.java:
##########
@@ -54,7 +55,10 @@ void testToIcebergSchemaWithPk() {
put(SinkConfig.TABLE_PRIMARY_KEYS.key(),
String.join(",", pks));
}
});
- Schema schema = SchemaUtils.toIcebergSchema(rowType, readonlyConfig);
+ Schema schema =
+ SchemaUtils.toIcebergSchema(
+ CatalogTableUtil.getCatalogTable("default",
rowType).getTableSchema(),
+ readonlyConfig);
Review Comment:
Can we add a test case of convert SeaTunnel catalog table (with comment) to
iceberg schema through `SchemaUtils.toIcebergSchema` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
