liunaijie commented on code in PR #7578:
URL: https://github.com/apache/seatunnel/pull/7578#discussion_r1758230348
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-common/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/AbstractJdbcIT.java:
##########
@@ -112,7 +112,7 @@ public abstract class AbstractJdbcIT extends TestSuiteBase
implements TestResour
abstract JdbcCase getJdbcCase();
- abstract void compareResult(String executeKey) throws SQLException,
IOException;
+ void checkResult(String executeKey, TestContainer container,
Container.ExecResult execResult) {}
Review Comment:
add more parameter to help check log.
and delete the abstract keyword, the implement class only need implement it
when necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
