Hisoka-X commented on code in PR #7666:
URL: https://github.com/apache/seatunnel/pull/7666#discussion_r1767825693


##########
docs/en/connector-v2/source/Redis.md:
##########
@@ -261,6 +256,45 @@ Redis {
 }
 ```
 
+read string type keys write append to list
+
+```hocon
+env {
+  parallelism = 1
+  job.mode = "BATCH"
+  shade.identifier = "base64"
+
+  #spark config
+  spark.app.name = "SeaTunnel"
+  spark.executor.instances = 2
+  spark.executor.cores = 1
+  spark.executor.memory = "1g"
+  spark.master = local

Review Comment:
   ```suggestion
   ```



##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-redis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java:
##########
@@ -343,12 +350,51 @@ public void testScanZsetTypeWriteRedis(TestContainer 
container)
             disabledReason = "Currently FLINK do not support multiple table 
read")
     public void testMultipletableRedisSink(TestContainer container)
             throws IOException, InterruptedException {
-        Container.ExecResult execResult =
-                container.executeJob("/fake-to-multipletableredissink.conf");
+        Container.ExecResult execResult = 
container.executeJob(testMultipletableRedisSinkConf());
         Assertions.assertEquals(0, execResult.getExitCode());
         jedis.select(3);
         Assertions.assertEquals(2, jedis.llen("key_multi_list"));
         jedis.del("key_multi_list");
         jedis.select(0);
     }
+
+    ///// need different redis version test override

Review Comment:
   We do need this any more?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to