sunxiaojian commented on PR #7660: URL: https://github.com/apache/seatunnel/pull/7660#issuecomment-2362930725
> > > Is there any need to modify here? https://github.com/apache/seatunnel/pull/7656/files#diff-75806c45c1b7d159a39a4442309885784ee116d510a2f147b347ab26db03e2b4R113 > > > > > > @hailin0 Don't need it > > @sunxiaojian > > Why is it needed here? > > https://github.com/apache/seatunnel/blob/4a2e27291c4d16d36ff4edaf70a67242ff78e9bf/seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/RowConverter.java#L221 Primary Keys are passed through configuration, so why not config them correctly ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
