Hisoka-X commented on PR #7385:
URL: https://github.com/apache/seatunnel/pull/7385#issuecomment-2367310220

   > I can move TimeplusSinkFactory to the same package as TimeplusSink, or the 
other way. But this follows the same pattern as ClickhouseSink and 
ClickhouseSinkFactory. Is there similar issue for clickhouse sink?
   
   Clickhouse Sink not use 
https://github.com/apache/seatunnel/pull/7385/files#diff-72c6df20268df8e1150ccebc7bc1261adb2686de701e5b245d4789bcea79b911R103
 at now. So we will not check it. We should update clickhouse sink in the 
future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to