Hisoka-X commented on code in PR #7713:
URL: https://github.com/apache/seatunnel/pull/7713#discussion_r1773220021
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-13-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SinkExecuteProcessor.java:
##########
@@ -170,10 +198,10 @@ public SeaTunnelSink fallbackCreateSink(
return source;
}
- public void handleSaveMode(SeaTunnelSink sink) {
- if (sink instanceof SupportSaveMode) {
- Optional<SaveModeHandler> saveModeHandler =
- ((SupportSaveMode) sink).getSaveModeHandler();
+ public void handleSaveMode(SeaTunnelSink seaTunnelSink) {
+ if (SupportSaveMode.class.isAssignableFrom(seaTunnelSink.getClass())) {
Review Comment:
```suggestion
if (seaTunnelSink instanceof SupportSaveMode) {
```
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SinkExecuteProcessor.java:
##########
@@ -176,10 +204,10 @@ public SeaTunnelSink fallbackCreateSink(
return source;
}
- public void handleSaveMode(SeaTunnelSink sink) {
- if (sink instanceof SupportSaveMode) {
- Optional<SaveModeHandler> saveModeHandler =
- ((SupportSaveMode) sink).getSaveModeHandler();
+ public void handleSaveMode(SeaTunnelSink seaTunnelSink) {
+ if (SupportSaveMode.class.isAssignableFrom(seaTunnelSink.getClass())) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
