Hisoka-X commented on code in PR #7703:
URL: https://github.com/apache/seatunnel/pull/7703#discussion_r1773253428
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:
##########
@@ -180,6 +180,7 @@ public void internalPollNext(Collector<SeaTunnelRow>
output) throws Exception {
} else {
if (httpParameter.getPollIntervalMillis() > 0) {
Thread.sleep(httpParameter.getPollIntervalMillis());
+ internalPollNext(output);
Review Comment:
I recheck it and this code might cause a stack overflow.
I think we should override
https://github.com/apache/seatunnel/blob/71b8b943903ec8ff3868f104e5dc979fccf34bd5/seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/AbstractSingleSplitReader.java#L34
in `HttpSourceReader`.
Then let engine to invoke `pollNext` in the loop, so that the job would be
streaming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
