arshadmohammad commented on code in PR #218:
URL: https://github.com/apache/seatunnel-web/pull/218#discussion_r1774487200
##########
seatunnel-datasource/seatunnel-datasource-plugins/datasource-jdbc-hive/src/main/java/org/apache/seatunnel/datasource/plugin/hive/jdbc/HiveJdbcDataSourceFactory.java:
##########
@@ -28,17 +28,17 @@
public class HiveJdbcDataSourceFactory implements DataSourceFactory {
@Override
public String factoryIdentifier() {
- return "Hive-JDBC";
+ return "JDBC-Hive";
}
@Override
public Set<DataSourcePluginInfo> supportedDataSources() {
DataSourcePluginInfo dataSourcePluginInfo =
DataSourcePluginInfo.builder()
- .name("Hive-JDBC")
+ .name("JDBC-Hive")
.type(DatasourcePluginTypeEnum.DATABASE.getCode())
.version("1.0.0")
- .icon("Hive-JDBC")
+ .icon("JDBC-Hive")
Review Comment:
The review comment has been addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
