Hisoka-X commented on code in PR #7832:
URL: https://github.com/apache/seatunnel/pull/7832#discussion_r1799339510
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oceanbase/OceanBaseMySqlCatalog.java:
##########
@@ -201,8 +209,7 @@ public CatalogTable getTable(String sqlQuery) throws
SQLException {
try (Statement statement = defaultConnection.createStatement();
ResultSet resultSet = statement.executeQuery(sqlQuery)) {
ResultSetMetaData metaData = resultSet.getMetaData();
- return CatalogUtils.getCatalogTable(
- metaData, new OceanBaseMySqlTypeMapper(typeConverter),
sqlQuery);
+ return getCatalogTable(metaData, defaultConnection.getMetaData(),
sqlQuery);
Review Comment:
shall we update
https://github.com/apache/seatunnel/blob/e4e12245b90e994bce27ea90ac044e722888a8ae/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oceanbase/OceanBaseMySqlCatalog.java#L130
too?
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oceanbase/OceanBaseMySqlTypeConverter.java:
##########
@@ -510,4 +554,142 @@ public BasicTypeDefine<OceanBaseMysqlType>
reconvert(Column column) {
return builder.build();
}
+
+ public static List<Column> convert(DatabaseMetaData metadata, TablePath
tablePath)
Review Comment:
Can we merge this into
https://github.com/apache/seatunnel/blob/e4e12245b90e994bce27ea90ac044e722888a8ae/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oceanbase/OceanBaseMySqlTypeConverter.java#L109
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
