happyboy1024 commented on code in PR #7845:
URL: https://github.com/apache/seatunnel/pull/7845#discussion_r1802440439


##########
docs/en/connector-v2/sink/Hudi.md:
##########
@@ -115,9 +115,9 @@ Note: When this configuration corresponds to a single 
table, you can flatten the
 
 `max_commits_to_keep` The max commits to keep of hudi table.
 
-### auto_commit [boolean]

Review Comment:
   > why delete `auto_commit`?
   
   1.HoodieJavaWriteClient is auto commit by default when not configure this.
   2.Due to the nature of hudi timelines, data needs to be submitted 
immediately after the data is writed or deleted, If not next flush will not 
aware data state of the previous batch. This may result in duplicate data or 
loss of deleted data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to