XenosK commented on code in PR #7840:
URL: https://github.com/apache/seatunnel/pull/7840#discussion_r1802266157
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/source/enumerator/splitter/AbstractJdbcSourceChunkSplitter.java:
##########
@@ -379,12 +380,38 @@ protected SnapshotSplit createSnapshotSplit(
protected Column getSplitColumn(
JdbcConnection jdbc, JdbcDataSourceDialect dialect, TableId
tableId)
throws SQLException {
- Optional<PrimaryKey> primaryKey = dialect.getPrimaryKey(jdbc, tableId);
Column splitColumn = null;
+ Table table = dialect.queryTableSchema(jdbc, tableId).getTable();
+
+ // first , compare user defined split column is in the primary key or
unique key
+ Properties splitColumnProperties = new Properties();
Review Comment:
> Why not just use Map?
org.apache.seatunnel.connectors.cdc.base.config.BaseSourceConfig , I see
dbzProperties use Properties, so do the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
