Hisoka-X commented on code in PR #7463:
URL: https://github.com/apache/seatunnel/pull/7463#discussion_r1819970827
##########
seatunnel-engine/seatunnel-engine-client/src/main/java/org/apache/seatunnel/engine/client/job/ClientJobExecutionEnvironment.java:
##########
@@ -99,13 +100,21 @@ public ClientJobExecutionEnvironment(
/** Search all jars in SEATUNNEL_HOME/plugins */
@Override
protected MultipleTableJobConfigParser getJobConfigParser() {
+ List<JobPipelineCheckpointData> pipelineCheckpoints =
Collections.emptyList();
+ if (isStartWithSavePoint) {
+ LOGGER.info("Start with savepoint, load checkpoint state from job
client");
+ pipelineCheckpoints =
+ jobClient.getCheckpointData(
+
Long.parseLong(jobConfig.getJobContext().getJobId()));
+ }
Review Comment:
why we need get checkpoint states from server not from filesystem?
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSink.java:
##########
@@ -164,4 +168,13 @@ public List<TablePath> getSinkTables() {
public void setJobContext(JobContext jobContext) {
sinks.values().forEach(sink -> sink.setJobContext(jobContext));
}
+
+ @Override
+ public List<SchemaChangeType> supports() {
+ SeaTunnelSink firstSink =
sinks.entrySet().iterator().next().getValue();
Review Comment:
> For MultiTableSink it should only contain sinks of the same kind
Right for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
