Hisoka-X commented on code in PR #7787:
URL: https://github.com/apache/seatunnel/pull/7787#discussion_r1820319270
##########
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/seatunnel.yaml:
##########
@@ -33,4 +33,10 @@ seatunnel:
namespace: /tmp/seatunnel/checkpoint_snapshot/
http:
enable-http: false
- port: 8080
\ No newline at end of file
+ port: 8080
+ context-path: /seatunnel
Review Comment:
why add this?
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseLogService.java:
##########
@@ -47,73 +39,13 @@ public BaseLogService(NodeEngineImpl nodeEngine) {
/** Get configuration log path */
public String getLogPath() {
try {
- String routingAppender = "routingAppender";
- String fileAppender = "fileAppender";
- PropertiesConfiguration config = getLogConfiguration();
- // Get routingAppender log file path
- String routingLogFilePath = getRoutingLogFilePath(config);
-
- // Get fileAppender log file path
- String fileLogPath = getFileLogPath(config);
- String logRef =
-
config.getLoggerConfig(StringUtils.EMPTY).getAppenderRefs().stream()
- .map(Object::toString)
- .filter(
- ref ->
- ref.contains(routingAppender)
- ||
ref.contains(fileAppender))
- .findFirst()
- .orElse(StringUtils.EMPTY);
- if (logRef.equals(routingAppender)) {
- return routingLogFilePath.substring(0,
routingLogFilePath.lastIndexOf("/"));
- } else if (logRef.equals(fileAppender)) {
- return fileLogPath.substring(0,
routingLogFilePath.lastIndexOf("/"));
- } else {
- log.warn(String.format("Log file path is empty, get logRef :
%s", logRef));
- return null;
- }
+ return LogUtil.getLogPath();
Review Comment:
cc @zhangshenghang
##########
docs/en/seatunnel-engine/logging.md:
##########
@@ -92,6 +92,24 @@ SeaTunnel provides an API for querying logs.
For more details, please refer to the [REST-API](rest-api-v2.md).
+### SeaTunnel Log Configuration
Review Comment:
```suggestion
## SeaTunnel Log Configuration
```
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -400,6 +405,17 @@ public boolean preApplyResources() {
== preApplyResourceFutures.size();
if (enoughResource) {
+ for (Map.Entry<TaskGroupLocation, CompletableFuture<SlotProfile>>
entry :
+ preApplyResourceFutures.entrySet()) {
+ try {
+ Address worker = entry.getValue().get().getWorker();
+ historyExecutionPlan.add(
+ new ExecutionAddress(worker.getHost(),
worker.getPort()));
+
+ } catch (Exception e) {
+ LOGGER.warning("history execution plan add worker failed",
e);
+ }
+ }
Review Comment:
cc @zhangshenghang for a look.
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/DAGUtils.java:
##########
@@ -52,7 +54,8 @@ public static JobDAGInfo getJobDAGInfo(
LogicalDag logicalDag,
JobImmutableInformation jobImmutableInformation,
EngineConfig engineConfig,
- boolean isPhysicalDAGIInfo) {
+ boolean isPhysicalDAGIInfo,
+ Set<ExecutionAddress> historyExecutionPlan) {
Review Comment:
```suggestion
Set<ExecutionAddress> historyExecutionAddress) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
