Hisoka-X commented on code in PR #7899:
URL: https://github.com/apache/seatunnel/pull/7899#discussion_r1827144989
##########
docs/en/transform-v2/dynamic-compile.md:
##########
@@ -88,7 +88,7 @@ transform {
compile_pattern="SOURCE_CODE"
source_code="""
import org.apache.seatunnel.api.table.catalog.Column
- import
org.apache.seatunnel.transform.common.SeaTunnelRowAccessor
+ import
org.apache.seatunnel.api.table.type.SeaTunnelRowAccessor
Review Comment:
Can we keep the old `SeaTunnelRowAccessor` class too? To make sure the old
dynamic config can work well too.
##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/seatunnel/SeaTunnelContainer.java:
##########
@@ -490,6 +494,29 @@ public Container.ExecResult cancelJob(String jobId) throws
IOException, Interrup
return cancelJob(server, jobId);
}
+ @Override
+ public String getJobStatus(String jobId) {
+ HttpGet get =
+ new HttpGet(
+ "http://";
+ + server.getHost()
+ + ":5801/hazelcast/rest/maps/job-info/"
Review Comment:
please use our new rest api v2.
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/CommonOptions.java:
##########
@@ -30,18 +30,44 @@ public enum CommonOptions {
/**
* The key of {@link Column#getOptions()} to specify the column value is a
json format string.
*/
- JSON("Json"),
+ JSON("Json", 0),
/** The key of {@link Column#getOptions()} to specify the column value is
a metadata field. */
- METADATA("Metadata"),
+ METADATA("Metadata", 0),
/**
* The key of {@link SeaTunnelRow#getOptions()} to store the partition
value of the row value.
*/
- PARTITION("Partition"),
- ;
+ PARTITION("Partition", 1),
+ /**
+ * The key of {@link SeaTunnelRow#getOptions()} to store the DATABASE
value of the row value.
+ */
+ DATABASE("Database", 1),
+ /** The key of {@link SeaTunnelRow#getOptions()} to store the TABLE value
of the row value. */
+ TABLE("Table", 1),
+ /**
+ * The key of {@link SeaTunnelRow#getOptions()} to store the ROW_KIND
value of the row value.
+ */
+ ROW_KIND("RowKind", 1),
+ /**
+ * The key of {@link SeaTunnelRow#getOptions()} to store the EVENT_TIME
value of the row value.
+ */
+ EVENT_TIME("EventTime", 1),
+ /** The key of {@link SeaTunnelRow#getOptions()} to store the DELAY value
of the row value. */
+ DELAY("Delay", 1);
private final String name;
+ private final int supportMetadataTrans;
- CommonOptions(String name) {
+ CommonOptions(String name, int supportMetadataTrans) {
Review Comment:
why `supportMetadataTrans` is int not boolean?
##########
docs/en/transform-v2/metadata.md:
##########
@@ -0,0 +1,82 @@
+# Metadata
+
+> Metadata transform plugin
+
+## Description
+Metadata transform plugin for adding metadata fields to data
+
+## Available Metadata
+
+| Key | DataType | Description
|
+|:---------:|:--------:|:---------------------------------------------------------------------------------------------------|
+| Database | string | Name of the table that contain the row.
|
+| Table | string | Name of the table that contain the row.
|
+| RowKind | string | The type of operation
|
+| EventTime | Long | The time at which the connector processed the event.
|
+| Delay | Long | The difference between data extraction time and
database change time |
Review Comment:
Can we should tell to users it only worked on cdc series connectors for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
