hawk9821 commented on code in PR #8002: URL: https://github.com/apache/seatunnel/pull/8002#discussion_r1837640975
########## docs/en/connector-v2/sink/Paimon.md: ########## @@ -31,7 +31,7 @@ libfb303-xxx.jar Review Comment: Piamon version 0.7 is incompatible with version 0.9. You are advised to provide the mapping between the ST Paimon Connector and the Paimon version. ########## docs/en/connector-v2/sink/Paimon.md: ########## @@ -46,6 +46,7 @@ libfb303-xxx.jar | paimon.table.write-props | Map | No | - | Properties passed through to paimon table initialization, [reference](https://paimon.apache.org/docs/master/maintenance/configurations/#coreoptions). | | paimon.hadoop.conf | Map | No | - | Properties in hadoop conf | | paimon.hadoop.conf-path | String | No | - | The specified loading path for the 'core-site.xml', 'hdfs-site.xml', 'hive-site.xml' files | +| paimon.fs.conf | Map | No | - | Properties when the catalog type is filesystem | Review Comment: please add `paimon.fs.conf ` examples ########## seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/config/PaimonConfig.java: ########## @@ -106,6 +106,12 @@ public class PaimonConfig implements Serializable { .withDescription( "The specified loading path for the 'core-site.xml', 'hdfs-site.xml', 'hive-site.xml' files"); + public static final Option<Map<String, String>> FS_CONF = Review Comment: What is the purpose of `paimon.fs.conf` configuration? Integrate `oss` `s3` configuration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
