Hisoka-X commented on code in PR #8016:
URL: https://github.com/apache/seatunnel/pull/8016#discussion_r1839200228
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/SystemFunction.java:
##########
@@ -70,11 +68,13 @@ public static Object nullif(List<Object> args) {
return v1;
}
- public static Object array(List<Object> args) {
+ public static String[] array(List<Object> args) {
Review Comment:
> Then we need to dynamically generate the returned ArrayType.
+1, we can reuse
https://github.com/apache/seatunnel/blob/d2576ff13112b0f845930374632a959cf29e7eb9/seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/TypeUtil.java#L23
to check and convert type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
