Re: [PR] [Bugfix][Kafka] In kafka flow mode, stop offse should be Long.MAX_VALUE [seatunnel]

Thu, 14 Nov 2024 02:37:31 -0800 


liunaijie commented on code in PR #7871:
URL: https://github.com/apache/seatunnel/pull/7871#discussion_r1841991174


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -344,6 +351,11 @@ private static int getSplitOwner(TopicPartition tp, int 
numReaders) {
     private Map<TopicPartition, Long> listOffsets(
             Collection<TopicPartition> partitions, OffsetSpec offsetSpec)
             throws ExecutionException, InterruptedException {
+
+        if (isStreamingMode) {
+            return Collections.emptyMap();
+        }

Review Comment:
   
![image](https://github.com/user-attachments/assets/022c9e46-9377-4b07-909d-608569e245a2)
   
   There only consume the data less than Stop offset.
   If this record is on the middle of `poll` result, How to commit the offset?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to