dailai commented on code in PR #8082: URL: https://github.com/apache/seatunnel/pull/8082#discussion_r1866925396
########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/resources/ddl/change_columns.sql: ########## @@ -0,0 +1,36 @@ +-- Review Comment: ditto. ########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/resources/ddl/modify_columns.sql: ########## @@ -0,0 +1,36 @@ +-- Review Comment: ditto ########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/resources/ddl/add_columns.sql: ########## @@ -0,0 +1,83 @@ +-- Review Comment: No need to copy an ddl sql from mysql-cdc e2e, you can add maven depencency and then use it directly. ########## seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/datatypes/StarRocksTypeConverter.java: ########## @@ -0,0 +1,648 @@ +/* Review Comment: Please add UT for this. ########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/resources/ddl/shop.sql: ########## @@ -0,0 +1,44 @@ +-- Review Comment: ditto. ########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/resources/ddl/drop_columns.sql: ########## @@ -0,0 +1,50 @@ +-- Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
