Hisoka-X commented on code in PR #8231:
URL: https://github.com/apache/seatunnel/pull/8231#discussion_r1875250471
##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/config/SinkConfig.java:
##########
@@ -83,4 +83,11 @@ public class SinkConfig {
Arrays.asList(DROP_DATA, APPEND_DATA,
ERROR_WHEN_DATA_EXISTS))
.defaultValue(APPEND_DATA)
.withDescription("data_save_mode");
+
+ public static final Option<String> PARENT_FIELD =
Review Comment:
please update the doc
##########
seatunnel-connectors-v2/connector-elasticsearch/src/test/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/ElasticsearchRowSerializerTest.java:
##########
@@ -71,8 +71,6 @@ public void testSerializeUpsert() {
+ "\"} }\n"
+ "{ \"doc\" :{\"name\":\""
+ name
- + "\",\"id\":\""
- + id
Review Comment:
why delete this?
##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/dto/IndexInfo.java:
##########
@@ -38,5 +39,8 @@ public IndexInfo(String index, ReadonlyConfig config) {
primaryKeys = config.get(SinkConfig.PRIMARY_KEYS).toArray(new
String[0]);
}
keyDelimiter = config.get(SinkConfig.KEY_DELIMITER);
+ if (config.getOptional(SinkConfig.PARENT_FIELD).isPresent()) {
+ parentField = config.get(SinkConfig.PARENT_FIELD);
+ }
Review Comment:
```suggestion
parentField = config.get(SinkConfig.PARENT_FIELD);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
