Hisoka-X commented on code in PR #8237:
URL: https://github.com/apache/seatunnel/pull/8237#discussion_r1875407953
##########
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/util/SchemaUtils.java:
##########
@@ -138,6 +138,15 @@ public static void applySchemaChange(
try (Statement statement = connection.createStatement()) {
log.info("Executing change column SQL: " + changeColumnSQL);
statement.execute(changeColumnSQL);
+ } catch (SQLException e) {
+ // from v3.3.2 onwards, StarRocks supports renaming columns
+ // if use previous starrocks version, program will be terminal
+ // suggest the sqlexception. programe will continue running
+ log.warn(
+ "Executing change column SQL: {}, Error Message: {}",
+ changeColumnSQL,
+ e.getMessage());
+ e.printStackTrace();
Review Comment:
I think we can precheck the starrocks version, when the version is less than
3.3.2, we can skip execute alter table field name. Instead of catch exception
when sql execute failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
