NookVoive opened a new issue, #8289: URL: https://github.com/apache/seatunnel/issues/8289
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happened When I want to write data from HDFS to HDFS, I want to achieve delete and then insert by configuring the data_save_mode. However, after configuring this parameter, it did not take effect. Upon reviewing the source code, I found that this configuration item was not implemented in the code. ```java /* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.seatunnel.connectors.seatunnel.file.hdfs.sink; import org.apache.seatunnel.shade.com.typesafe.config.Config; import org.apache.seatunnel.api.common.PrepareFailException; import org.apache.seatunnel.api.common.SeaTunnelAPIErrorCode; import org.apache.seatunnel.common.config.CheckConfigUtil; import org.apache.seatunnel.common.config.CheckResult; import org.apache.seatunnel.common.constants.PluginType; import org.apache.seatunnel.connectors.seatunnel.file.config.BaseSinkConfig; import org.apache.seatunnel.connectors.seatunnel.file.config.HadoopConf; import org.apache.seatunnel.connectors.seatunnel.file.exception.FileConnectorException; import org.apache.seatunnel.connectors.seatunnel.file.sink.BaseFileSink; import java.util.Objects; import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.FS_DEFAULT_NAME_KEY; public abstract class BaseHdfsFileSink extends BaseFileSink { @Override public void prepare(Config pluginConfig) throws PrepareFailException { CheckResult result = CheckConfigUtil.checkAllExists(pluginConfig, FS_DEFAULT_NAME_KEY); if (!result.isSuccess()) { throw new FileConnectorException( SeaTunnelAPIErrorCode.CONFIG_VALIDATION_FAILED, String.format( "PluginName: %s, PluginType: %s, Message: %s", getPluginName(), PluginType.SINK, result.getMsg())); } super.prepare(pluginConfig); // Avoid overwriting hadoopConf for subclass initialization. If a subclass is initialized, // it is not initialized here. if (Objects.isNull(hadoopConf)) { hadoopConf = new HadoopConf(pluginConfig.getString(FS_DEFAULT_NAME_KEY)); } if (pluginConfig.hasPath(BaseSinkConfig.HDFS_SITE_PATH.key())) { hadoopConf.setHdfsSitePath(pluginConfig.getString(BaseSinkConfig.HDFS_SITE_PATH.key())); } if (pluginConfig.hasPath(BaseSinkConfig.REMOTE_USER.key())) { hadoopConf.setRemoteUser(pluginConfig.getString(BaseSinkConfig.REMOTE_USER.key())); } if (pluginConfig.hasPath(BaseSinkConfig.KRB5_PATH.key())) { hadoopConf.setKrb5Path(pluginConfig.getString(BaseSinkConfig.KRB5_PATH.key())); } if (pluginConfig.hasPath(BaseSinkConfig.KERBEROS_PRINCIPAL.key())) { hadoopConf.setKerberosPrincipal( pluginConfig.getString(BaseSinkConfig.KERBEROS_PRINCIPAL.key())); } if (pluginConfig.hasPath(BaseSinkConfig.KERBEROS_KEYTAB_PATH.key())) { hadoopConf.setKerberosKeytabPath( pluginConfig.getString(BaseSinkConfig.KERBEROS_KEYTAB_PATH.key())); } } } ``` 当我想要把数据从HDFS写入到HDFS时，想要通过配置 data_save_mode 实现删除再插入， 但是配置该 参数后并未生效。 经过查看源代码发现该配置项并未在代码中实现。 ### SeaTunnel Version 2.3.8 ### SeaTunnel Config ```conf env { parallelism = 1 job.mode = "BATCH" } source { HdfsFile { fs.defaultFS = "hdfs://xxxxxx:8020" file_format_type = "parquet" path = "/user/hive/warehouse/dwh_ods_jt.db/mytable" } } sink { HdfsFile { fs.defaultFS = "hdfs://xxxxxx:8020" remote_user = "hive" schema_save_mode = "ERROR_WHEN_SCHEMA_NOT_EXIST" data_save_mode = "DROP_DATA" file_format_type = "parquet" path = "/user/hive/warehouse/dwh_ods_jt.db/mytable" } } ``` ### Running Command ```shell bash $SEATUNNEL_HOME/bin/seatunnel.sh -c /config/test.conf -e local ``` ### Error Exception ```log No Error But the old files exists! ``` ### Zeta or Flink or Spark Version _No response_ ### Java or Scala Version _No response_ ### Screenshots _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
