Hisoka-X commented on code in PR #8296:
URL: https://github.com/apache/seatunnel/pull/8296#discussion_r1886087408
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/util/ClickhouseProxy.java:
##########
@@ -274,6 +274,58 @@ public ClickhouseTable getClickhouseTable(String database,
String table) {
}
}
+ /**
+ * Get ClickHouse table info for shard node.
+ *
+ * @param request
+ * @param database
+ * @param table
+ * @return
+ */
+ public ClickhouseTable getClickhouseTableForShardNode(
+ ClickHouseRequest<?> request, String database, String table) {
Review Comment:
This method is totally seem as
https://github.com/apache/seatunnel/pull/8296/files#diff-ec9cf2e8c4d74f805e8558e079dcd9941afed65045288075c9766fe07b487ab7L234.
Could you do some refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
