dailai commented on code in PR #8333:
URL: https://github.com/apache/seatunnel/pull/8333#discussion_r1891200336
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java:
##########
@@ -182,7 +185,7 @@ public PaimonSinkWriter(
.flatMap(List::stream)
.collect(Collectors.toList());
log.info("Trying to recommit states {}", commitables);
- if (JobContextUtil.isBatchJob(jobContext)) {
+ if (JobContextUtil.isCheckpointNotEnabledInBatchMode(jobContext,
envConfig)) {
Review Comment:
Also, this code is inherited from history, I just added a condition. I don't
think we should commit here. I'll do a separate pr and just restore the state
without committing.
##########
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java:
##########
@@ -182,7 +185,7 @@ public PaimonSinkWriter(
.flatMap(List::stream)
.collect(Collectors.toList());
log.info("Trying to recommit states {}", commitables);
- if (JobContextUtil.isBatchJob(jobContext)) {
+ if (JobContextUtil.isCheckpointNotEnabledInBatchMode(jobContext,
envConfig)) {
Review Comment:
It just be used should we use the commit of stream api or not. The stream
api can pass the checkpointId as an argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
