hawk9821 commented on code in PR #8323:
URL: https://github.com/apache/seatunnel/pull/8323#discussion_r1893459081
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mysql/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/source/MySqlIncrementalSourceFactory.java:
##########
@@ -99,9 +108,42 @@ public Class<? extends SeaTunnelSource> getSourceClass() {
TableSource<T, SplitT, StateT> restoreSource(
TableSourceFactoryContext context, List<CatalogTable>
restoreTables) {
return () -> {
+ ReadonlyConfig config = context.getOptions();
+ Optional<String> optional =
config.getOptional(CatalogOptions.TABLE_PATTERN);
Review Comment:
I see . let me verify . The captured tables must satisfy both the
`TABLE_PATTERN` and `DATABASE_NAMES` parameters.
```
2024-12-20 04:31:16,573 INFO
org.apache.seatunnel.connectors.seatunnel.cdc.mysql.utils.TableDiscoveryUtils
[] - Read list of available databases
2024-12-20 04:31:16,859 INFO
org.apache.seatunnel.connectors.seatunnel.cdc.mysql.utils.TableDiscoveryUtils
[] - list of available databases is: [source]
2024-12-20 04:31:16,860 INFO
org.apache.seatunnel.connectors.seatunnel.cdc.mysql.utils.TableDiscoveryUtils
[] - Read list of available tables in each database
2024-12-20 04:31:16,889 INFO io.debezium.jdbc.JdbcConnection
[] - Connection gracefully closed
2024-12-20 04:31:16,890 WARN io.debezium.connector.mysql.MySqlConnection
[] - Database configuration option 'serverTimezone' is set but is
obsolete, please use 'connectionTimeZone' instead
2024-12-20 04:31:16,908 INFO io.debezium.jdbc.JdbcConnection
[] - Connection gracefully closed
2024-12-20 04:31:16,912 INFO
org.apache.seatunnel.connectors.cdc.base.source.enumerator.SnapshotSplitAssigner
[] - SnapshotSplitAssigner created with remaining tables: [source.customers,
source.products]
2024-12-20 04:31:16,915 INFO
org.apache.seatunnel.connectors.cdc.base.source.enumerator.SnapshotSplitAssigner
[] - SnapshotSplitAssigner created with remaining splits: []
2024-12-20 04:31:16,916 INFO
org.apache.seatunnel.connectors.cdc.base.source.enumerator.SnapshotSplitAssigner
[] - SnapshotSplitAssigner created with assigned splits: []
```
When `TABLE_PATTERN` is configured, do you want the `DATABASE_NAMES`
configuration to not take effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
