hailin0 commented on code in PR #8356:
URL: https://github.com/apache/seatunnel/pull/8356#discussion_r1894001822
##########
seatunnel-connectors-v2/connector-assert/src/main/java/org/apache/seatunnel/connectors/seatunnel/assertion/sink/AssertSinkWriter.java:
##########
@@ -102,6 +103,13 @@ public void write(SeaTunnelRow element) {
@Override
public void close() {
+ try {
+ // When there are multiple AssertSinkWriters, some Sinks will run
first, so let it wait
+ // for other Sinks, otherwise it will make incorrect judgments
+ Thread.sleep(WAIT_SINK_WRITER_COMPLETE_TIME);
+ } catch (InterruptedException e) {
+ throw new RuntimeException(e);
+ }
Review Comment:
LGTM, but we should implement committer to final count check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
