Hisoka-X commented on code in PR #8401:
URL: https://github.com/apache/seatunnel/pull/8401#discussion_r1908111974
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/dag/actions/SinkConfig.java:
##########
@@ -25,5 +27,6 @@
@NoArgsConstructor
@AllArgsConstructor
public class SinkConfig implements Config {
- private String multipleRowTableId;
+ // private String multipleRowTableId;
Review Comment:
```suggestion
```
##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/parse/MultipleTableJobConfigParser.java:
##########
@@ -657,16 +658,18 @@ private static <T> T findLast(LinkedHashMap<?, T> map) {
log.info("Unsupported multi table sink api, rollback to sink
template");
return Optional.empty();
}
- Map<String, SeaTunnelSink> sinks = new HashMap<>();
+ Map<TablePath, SeaTunnelSink> sinks = new HashMap<>();
Set<URL> jars =
sinkActions.stream()
.flatMap(a -> a.getJarUrls().stream())
.collect(Collectors.toSet());
sinkActions.forEach(
action -> {
SeaTunnelSink sink = action.getSink();
- String tableId =
action.getConfig().getMultipleRowTableId();
- sinks.put(tableId, sink);
+ // String tableId =
+ // action.getConfig().getMultipleRowTableId();
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
