Hisoka-X commented on code in PR #8514:
URL: https://github.com/apache/seatunnel/pull/8514#discussion_r1915909982
##########
seatunnel-connectors-v2/connector-doris/src/main/java/org/apache/seatunnel/connectors/doris/config/DorisSinkOptions.java:
##########
@@ -134,6 +134,9 @@ public interface DorisSinkOptions {
+ " UNIQUE KEY ("
+
SaveModePlaceHolder.ROWTYPE_PRIMARY_KEY.getPlaceHolder()
+ ")\n"
+ + "COMMENT '"
Review Comment:
ditto
##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/config/MaxcomputeConfig.java:
##########
@@ -98,7 +98,9 @@ public class MaxcomputeConfig implements Serializable {
+ "` (\n"
+
SaveModePlaceHolder.ROWTYPE_FIELDS.getPlaceHolder()
+ "\n"
- + ");")
+ + ") comment '"
Review Comment:
ditto
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/config/ClickhouseConfig.java:
##########
@@ -228,7 +228,11 @@ public class ClickhouseConfig {
+
SaveModePlaceHolder.ROWTYPE_PRIMARY_KEY.getPlaceHolder()
+ ")\n"
+ "SETTINGS\n"
- + " index_granularity = 8192;")
+ + " index_granularity = 8192"
+ + "\n"
+ + "COMMENT '"
+ +
SaveModePlaceHolder.COMMENT.getPlaceHolder()
+ + "';")
Review Comment:
The default value changed. We should update each doc too.
https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/sink/Clickhouse.md#save_mode_create_template
##########
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/config/StarRocksSinkOptions.java:
##########
@@ -71,6 +71,9 @@ public interface StarRocksSinkOptions {
+ " PRIMARY KEY ("
+
SaveModePlaceHolder.ROWTYPE_PRIMARY_KEY.getPlaceHolder()
+ ")\n"
+ + "COMMENT '"
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
