arshadmohammad commented on code in PR #269:
URL: https://github.com/apache/seatunnel-web/pull/269#discussion_r1918690664
##########
seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/service/impl/UserServiceImpl.java:
##########
@@ -60,6 +69,29 @@ public class UserServiceImpl implements IUserService {
@Value("${user.default.passwordSalt:seatunnel}")
private String defaultSalt;
+ private final Map<String, IAuthenticationStrategy> strategies = new
HashMap<>();
+
+ @Autowired private DBAuthenticationStrategy dbAuthenticationStrategy;
+
+ @Autowired private LDAPAuthenticationStrategy ldapAuthenticationStrategy;
+
+ @Autowired
+ private SeatunnelAuthenticationProvidersConfig
seatunnelAuthenticationProvidersConfig;
+
+ @PostConstruct
+ public void init() {
+ if (seatunnelAuthenticationProvidersConfig
Review Comment:
I see at least one place when default is not taken care
`public UserSimpleInfoRes login(UserLoginReq req, String authType) {
if (StringUtils.isNotEmpty(authType) &&
!strategies.containsKey(authType)) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
