liugddx commented on code in PR #8536:
URL: https://github.com/apache/seatunnel/pull/8536#discussion_r1922045077


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/FactoryUtil.java:
##########
@@ -65,31 +73,53 @@ public final class FactoryUtil {
 
     public static <T, SplitT extends SourceSplit, StateT extends Serializable>
             Tuple2<SeaTunnelSource<T, SplitT, StateT>, List<CatalogTable>> 
createAndPrepareSource(
-                    ReadonlyConfig options, ClassLoader classLoader, String 
factoryIdentifier) {
-        return restoreAndPrepareSource(options, classLoader, 
factoryIdentifier, null);
+                    ReadonlyConfig options,
+                    ClassLoader classLoader,
+                    String factoryIdentifier,
+                    Function<PluginIdentifier, SeaTunnelSource> 
createSourceFunction) {

Review Comment:
   Done.



##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/FactoryUtil.java:
##########
@@ -150,7 +181,8 @@ SeaTunnelSink<IN, StateT, CommitInfoT, 
AggregatedCommitInfoT> createAndPrepareSi
                     CatalogTable catalogTable,
                     ReadonlyConfig config,
                     ClassLoader classLoader,
-                    String factoryIdentifier) {
+                    String factoryIdentifier,
+                    Function<PluginIdentifier, SeaTunnelSink> 
createSinkFunction) {

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to