Hisoka-X commented on code in PR #8434:
URL: https://github.com/apache/seatunnel/pull/8434#discussion_r1926417932
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -67,6 +67,7 @@ They can be downloaded via install-plugin.sh or from the
Maven central repositor
| connect_timeout_ms | Int | No | 12000 | Connection
timeout setting, default 12s.
|
| socket_timeout_ms | Int | No | 60000 | Socket timeout
setting, default 60s.
|
| common-options | | No | - | Source plugin
common parameters, please refer to [Source Common
Options](../source-common-options.md) for details |
+| keep_params_as_form | | No | - | Whether the
params are submitted according to the form
|
Review Comment:
```suggestion
| keep_params_as_form | Boolean | No | false |
Whether the params are submitted according to the form, used for compatibility
with legacy behaviors. When true, the value of the params parameter is
submitted through the form.
|
```
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -346,6 +347,15 @@ source {
```
+### keep_params_as_form
+When set to true,params and page params will be submitted in the form.
+If the submission is application/json format,please do not set this value.
+
+### params
+By default, the parameters will be added to the url path.
+If form submission is required,please set keep_params_as_form true.
+
+
Review Comment:
```suggestion
```
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -69,8 +76,11 @@ public class HttpConfig {
.withDescription("Http request headers");
public static final Option<Map<String, String>> PARAMS =
Options.key("params").mapType().noDefaultValue().withDescription("Http request
params");
- public static final Option<String> BODY =
-
Options.key("body").stringType().noDefaultValue().withDescription("Http request
body");
+ public static final Option<Map<String, Object>> BODY =
Review Comment:
please revert.
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpParameter.java:
##########
@@ -29,10 +30,13 @@
@SuppressWarnings("MagicNumber")
public class HttpParameter implements Serializable {
protected String url;
+ protected boolean enabledOldSubmit = false;
Review Comment:
useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
