liunaijie commented on code in PR #8580:
URL: https://github.com/apache/seatunnel/pull/8580#discussion_r1926615120
##########
seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/config/ActivemqSinkOptions.java:
##########
@@ -17,56 +17,12 @@
package org.apache.seatunnel.connectors.seatunnel.activemq.config;
-import
org.apache.seatunnel.shade.com.google.common.annotations.VisibleForTesting;
-import org.apache.seatunnel.shade.com.typesafe.config.Config;
-
import org.apache.seatunnel.api.configuration.Option;
import org.apache.seatunnel.api.configuration.Options;
-import lombok.AllArgsConstructor;
-import lombok.Getter;
-import lombok.Setter;
-
import java.io.Serializable;
-import java.util.HashMap;
-import java.util.Map;
-
-@Setter
-@Getter
-@AllArgsConstructor
-public class ActivemqConfig implements Serializable {
- private String host;
- private Integer port;
- private String username;
- private String password;
- private String uri;
- private String queueName;
- private Boolean checkForDuplicate;
- private String clientID;
- private Integer closeTimeout;
- private Boolean consumerExpiryCheckEnabled;
- private Boolean copyMessageOnSend;
- private Boolean disableTimeStampsByDefault;
- private Boolean dispatchAsync;
- private Boolean nestedMapAndListEnabled;
- private Boolean useCompression;
- private Boolean alwaysSessionAsync;
- private Boolean alwaysSyncSend;
- private Integer warnAboutUnstartedConnectionTimeout;
-
- private final Map<String, Object> sinkOptionProps = new HashMap<>();
-
- public static final Option<String> HOST =
Review Comment:
Those parameters are defined, but not used. So I delete them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
